Testing framework#1902
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8125556c53
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| if [ -s .gitdiff ]; then | ||
| exit 0; # disabled |
There was a problem hiding this comment.
The makedepend-check job now returns success even when misc/makedepend modifies tracked files, because the non-empty diff branch exits with 0. In CI this silently disables the regression guard that previously enforced committed dependency updates, so PRs can merge with stale generated dependency data and only fail later in downstream builds or packaging flows.
Useful? React with 👍 / 👎.
thommey
force-pushed
the
testing-framework
branch
5 times, most recently
from
d7581eb to
0cc25ce
Compare
thommey
force-pushed
the
testing-framework
branch
from
207d34f to
06ded0f
Compare
Only some of them, rest is documented in README.md
Not sure why tests are significantly slower on Github (10m+ instead of 40s), presumably this issue: astral-sh/uv#9765 Using system python significantly speeds it up
This perfectly finds the regression caused by 2fea6c4 which intended to fix issues with the extra ":". Broken: 1.10.1 Valid: 1.10.0 and latest HEAD because of gotmode() using parse_irc now
thommey
force-pushed
the
testing-framework
branch
from
06ded0f to
1e0fe38
Compare
2 participants
One-line summary: AI written pytest based tests for Eggdrop. No changes to Eggdrop source code. uv is recommended but not required to run them.
Additional description (if needed): In the future we can add Tcl commands to introspect C state, guarded by #ifdef TESTING only. See testing/README.md for a longer description and architectural details.
It pretty much does what the eggdrop-test repository did with a few more modern changes:
Test cases demonstrating functionality (if applicable):